Skip to content

[PWGLF] Added histograms for FV0 Mult vs Flattenicity - #9876

Merged
njacazio merged 1 commit into
AliceO2Group:masterfrom
sprasadphy:master
Feb 11, 2025
Merged

[PWGLF] Added histograms for FV0 Mult vs Flattenicity#9876
njacazio merged 1 commit into
AliceO2Group:masterfrom
sprasadphy:master

Conversation

@sprasadphy

Copy link
Copy Markdown
Contributor

No description provided.

@njacazio
njacazio enabled auto-merge (squash) February 11, 2025 13:24
@njacazio

Copy link
Copy Markdown
Collaborator

Hi @imsurajprasad786 could you also fix the megalinter in a coming PR?

@sprasadphy

Copy link
Copy Markdown
Contributor Author

Hi @imsurajprasad786 could you also fix the megalinter in a coming PR?

Yes @njacazio, I shall fix them in my next PR. Thank you.

@vkucera

vkucera commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

@imsurajprasad786 Why are you renaming the configurables to names incompatible with the naming conventions?

@sprasadphy

Copy link
Copy Markdown
Contributor Author

@imsurajprasad786 Why are you renaming the configurables to names incompatible with the naming conventions?

Hello, @vkucera. I was trying to make the configurable names consistent with the "d_UseAutodetectMode" (https://aliceo2group.github.io/analysis-framework/docs/advanced-specifics/pwglf.html?highlight=autodetect#topological-selection-autodetect-in-strangeness-builders). But I think I made more than the necessary changes, which I must fix. I should fix them all or keeping the necessary configurables consistent with AutoDetectMode is fine? Also, can I fix them in my next PR?

@njacazio
njacazio merged commit cf45351 into AliceO2Group:master Feb 11, 2025
@vkucera

vkucera commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

@imsurajprasad786 Why are you renaming the configurables to names incompatible with the naming conventions?

Hello, @vkucera. I was trying to make the configurable names consistent with the "d_UseAutodetectMode" (https://aliceo2group.github.io/analysis-framework/docs/advanced-specifics/pwglf.html?highlight=autodetect#topological-selection-autodetect-in-strangeness-builders). But I think I made more than the necessary changes, which I must fix. I should fix them all or keeping the necessary configurables consistent with AutoDetectMode is fine? Also, can I fix them in my next PR?

Thanks for the explanation. It is unfortunate that the official LF utilities use non-conventional names, but I understand your motivation.

nasirmehdimalik pushed a commit to nasirmehdimalik/O2Physics that referenced this pull request Feb 12, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants